ng packagr does not remove devDependencies

Type of Issue

[ X ] Bug Report
[ ] Feature Request

Description

ng-packagr 4.0.1

A bug: please describe the error that you encountered

• ng-packagr copies devDependencies to the final package.json even though they are not whitelisted.

• i have angular in peerDependencies and devDependencies

• as a consequence i get an invalid “package” (i.e. npm link will install all those dependencies…)

• building an app with a linked library will not work

• the following error happens, because angular core is now referenced twice

ERROR in ../@foo/bar/foo-bar.ts(9,2): Error during template compile of 'FoobarModule'

  Function calls are not supported in decorators but 'ɵmakeDecorator' was called in 'NgModule'

    'NgModule' calls 'ɵmakeDecorator'.

node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'.

node_modules/@foo/bar/node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'.

Expected Behaviour

A bug: please describe what behaviour or result you expected

• devDependencies should not be copied by default and only when they are whitelisted

Version Information

$ node_modules/.bin/ng-packagr --version
ng-packagr: 4.0.1
@angular/*: 6.1.0
typescript: 2.7.2
rxjs: 6.2.2
node: 8.11.3

[CarstenLeue]

@alan-agius4 independent of the discussion how npm link works, is there any usecase for including devDependencies in a package published to npm?

If not, I would second the request to remove devDependencies from the generated package.json, automatically (just as scripts are removed)

[alan-agius4]

Closing as this is not planned.