No name was provided for external module

Type of Issue

[ ] Bug Report
[ ] Feature Request
[x] Not sure :-)

Description

Once I upgraded to 2.2.0 I started seeing this error and I have tried so many things… any help would be greatly appreciated.

No name was provided for external module ‘commonjs-proxy:jquery’ in options.globals – guessing ‘require$$0’

I have the following ng-package.json defined:

{
  "$schema": "./node_modules/ng-packagr/ng-package.schema.json",
  "lib": {
    "entryFile": "public_api.ts",
    "embedded": ["ng-fullcalendar", "fullcalendar"],
    "umdModuleIds": {
      "jquery": "$",
      "moment": "moment",
      "commonjs-proxy:jquery": "$"  // Tried with this in and out
    }
  },
  "whitelistedNonPeerDependencies": ["."]
}

It seems like it’s an issue with the “fullcalendar” (https://github.com/fullcalendar/fullcalendar). It is compiled with webpack and looking at the dist file - it seems like it should work with rollup. Though I always get confused on the different bundling methods.

How To Reproduce

I will edit this with reproducing steps and will look at if it’s possible to break an integration test. Just thought I would put this out there first in case it’s something really obvious.

Version Information

$ node_modules/.bin/ng-packagr --version
ng-packagr:            2.4.1
@angular/compiler:     5.2.9
@angular/compiler-cli: 5.2.9
rollup:                0.55.5
tsickle:               0.27.2
typescript:            2.5.3

Please include all version numbers that might be relevant, e.g. third-party libraries

[codeNoobie]

@dherges @tommck I am new to using ng-packagr. I am getting the above errors as well.

I have declared a bunch of external libraries as peerDependencies. I do not want to include any code from third party in our bundle. But when i run ng-packagr, I get these errors. What does these errors mean? Is it trying to include the code from the third party libs and it would exactly do that if add those libs in the external array.

My goal is to not include anything from third party lib. The consumer of my lib will have to provide those external libs to make it work. What am i missing?

Thanks in advance for helping!

[github-actions[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. _{This action has been performed automatically by a bot.}