question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

undocumented breaking change in v3 : ng-packagr doesn't generate a tarball anymore

See original GitHub issue

Type of Issue

[ ] Bug Report
[ ] Feature Request
[x] documentation

(A feature request could be hadded to angular/devkit).

Description

When building a library, ng-packagr doesn’t generate any tarball anymore.

The expected behaviour was added by @filipesilva #715 See https://github.com/dherges/ng-packagr/commit/94bc915#diff-2e14a1a49f5dcec2e1af74d135633651R38

These regression was introduced by @alan-agius4 #738. See https://github.com/dherges/ng-packagr/commit/4e6c4f4bb21869c69f084560af3fa75531e4d07f#diff-2e14a1a49f5dcec2e1af74d135633651L133

But the breaking change wasn’t mentionned in https://github.com/dherges/ng-packagr/blob/master/CHANGELOG.md#breaking-changes.

How To Reproduce

The associated test (https://github.com/dherges/ng-packagr/commit/94bc91513767e965778df299862b7d28428a2491#diff-7590c1f6c6a53411a7569652cab76e3cR28) was removed (https://github.com/dherges/ng-packagr/commit/4e6c4f4bb21869c69f084560af3fa75531e4d07f#diff-7590c1f6c6a53411a7569652cab76e3cL27).

Expected Behaviour

As we could see in #738 discussion, the drop of the tarball generation seems to make sence (https://github.com/dherges/ng-packagr/pull/738#issuecomment-379457152).

So, we’ll need to :

  1. document this breaking change, especially how the tarball should be generated (with npm pack)
  2. make the associated evolution in @angular-devkit/build-ng-packagr

Version Information

ng-packagr:            3.0.0-rc.2
@angular/compiler:     5.2.10
@angular/compiler-cli: 5.2.10
rollup:                0.57.1
tsickle:               0.26.0
typescript:            2.6.2

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
alan-agius4commented, Apr 26, 2018

Just some takeouts though why it’s not part of the current build.

At the moment a lot of users have postbuild scripts in order to do some transformation in the bundle, example bundle scss files, add some other files. Generating a tarball from ng-packagr after the build steps would be invalid. (This is actually one of the problems with the initial approach https://github.com/dherges/ng-packagr/pull/715#issuecomment-378901242)

1reaction
noelmacecommented, Apr 26, 2018

@alan-agius4 no problem, I saw the discussion and it make sense. For now I will just add this as a postbuild in my project, and later I’ll look at devkit, to see if we could add this to the ng-packagr build architect.

Read more comments on GitHub >

github_iconTop Results From Across the Web

After update of either npm, or ng-packagr, publish tries to use ...
After migration to Node@16.14.2, NPM@8.5.0 and Angular@13 I am not able to publish package generated by ng-packager to npm repository.
Read more >
Release notes — fish-shell 3.5.1 documentation
Since fish 3.0, for loops would trigger a variable handler function before the loop was entered. As the variable had not actually changed...
Read more >
Blog | HHVM
Breaking Changes. Two compiler options have been renamed - when compiling a repo the compiler will no longer accept --module or --cmodule ...
Read more >
Untitled
... IPA upgrade due to broken ReplSync (DS 48030) Fixes spec file to make sure ... Update tarball URL in specfile (no actual...
Read more >
History - Apache Calcite
[CALCITE-5270] JDBC adapter should not generate FILTER (WHERE . ... This release contains some breaking changes due to the replacement of ImmutableBeans ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found