ng-option with null value causes empty selection

Describe the bug I have a use case where I need to add an option with null value. When the model’s value is null, the selection appears empty.

To Reproduce

<ng-select [(ngModel)]="dimensionalFilters.campaign" (ngModelChange)="generateReport()" 
       [clearable]="false">
       <ng-option [value]="null">Show All</ng-option>
       <ng-option *ngFor="let c of campaigns" [value]="c.id">{{ c.name }}</ng-option>
</ng-select>

Also, when selecting this option, the model is populated with {$ngOptionValue: null, $ngOptionLabel: "Show All", disabled: false}.

Expected behavior Show All should show up as selected and model value should be null.

Screenshots

Additional context Using a default select this works as expected. Option is selected and model’s value is set to null when selecting this option.

<select [(ngModel)]="dimensionalFilters.campaign" (ngModelChange)="generateReport()">
    <option [ngValue]="null">Show All</option>
    <option *ngFor="let c of campaigns" [ngValue]="c.id">{{ c.name }}</option>
</select>

[xxxKOTxxx]

If we add this change it could break a lot of functionality since we treat both null and undefined as empty or cleared state.

You treat wrong! Usage of -1/0/“i’m bad programmer”/etc. instead of null is the worst crutch I ever see.

I think it’s a bug and I think bugs must be fixed!

For breaking changes You can use major versions. To detect breaked of functionality we have testing.

Everything else - recognition of one’s own incompetence and justification of laziness.

Best regards, Boris.

[anjmao]

You can have a value something like -1 etc for such case and will will work just fine. If we add this change it could break a lot of functionality since we treat both null and undefined as empty or cleared state.

items = [
   { label: 'Select all', value: -1 }
   { label: 'One', value: 1 }
]

onChange(value) {
   if (value === -1) {
       // Treat the same as with null.
   }
}