nzBeforeUpload from nz-upload should have the file parameter of type File instance instead of UploadFile

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-ygithh?file=src/app/app.component.ts

Steps to reproduce

Use a nz-upload with a nzBeforeUpload attribute that returns false. Log the file parameter inside nzBeforeUpload.

What is expected?

I expect the argument type of the nzBeforeUpload function to be of type File instead of UploadFile as the function actually has inside Javascript

What is actually happening?

nzBeforeUpload has the wrong type definition for the file parameter of UploadFile instead of File.

Environment	Info
ng-zorro-antd	8.5.2
Browser	*

---

The type definition just needs to be changed to reflect what the function actually is called with: Now is:

nzBeforeUpload: (file: UploadFile, fileList: UploadFile[]) => boolean | Observable<boolean>;

It should be:

nzBeforeUpload: (file: File, fileList: File[]) => boolean | Observable<boolean>;

PS. I am not sure if the fileList parameter should be File[].

[krokofant]

Still broken in version 13. 😮

[adammruk]

I have exactly same case like @emondora. For now i use a small workaround: In my beforeUpload function i accept file as UploadFile:

beforeUpload = (file: UploadFile): Observable<boolean> => {

but later i’m just casting types:

reader.readAsDataURL(file as unknown as File);