question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature Request: Stop only connected VIN if it is populated

See original GitHub issue

It would be good to check currentVIN when requesting vehicles to stop charging via API.

It’s probably more complex than I am giving it credit for, though. For example, two Slave TWCs, one with VIN capability and one without. We drop below minAmpsPerTWC - what do we do? Perhaps what we need is a quorum where if all Slave TWCs are marked as supporting VINs, we only send stop messages to those VINs - otherwise we stop all vehicles per today’s behaviour. Or is this just an overly complex rabbit hole to go down?

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
MikeBishopcommented, Jul 8, 2020

Unless you’re envisioning a mode where one charger is allowed to proceed and the other isn’t (which there is a use for – two cars that want to charge, with available power between minAmpsPerTwc and 2*minAmpsPerTwc), I don’t see a real use for limiting the stop command to the TWC’s connected vehicle.

Actually, I take that back – a garage with both a TWC and an outlet, and TWCManager shouldn’t be stopping the car on the outlet. That’s fairly niche, though; I’d think if you’re investing in TWCs and TWCManager, you have one per car you intend to charge at once.

1reaction
MikeBishopcommented, Jul 8, 2020

I think another way you could scope it, since we’ve already taken the step of keeping home/not-home status for each car, is to send the stop command to all cars at home, instead of all cars. This already exists in the code, but it’s gated behind a default-off config value. Default on, or just remove the setting?

Read more comments on GitHub >

github_iconTop Results From Across the Web

API reference · Smartcar docs
All requests made to our API require an access token. ... Smartcar Connect will then let the user authorize only the vehicle with...
Read more >
Apple CarPlay not working – how to fix common CarPlay issues
Learn how to fix Apple CarPlay not working – connection problems, sound and microphone issues and more.
Read more >
Frequently Asked Questions - Uconnect® System FAQ
View frequently asked questions and answers about Uconnect®. Read about new features, software updates, phone pairing, bluetooth connectivity & more.
Read more >
Query Processing Architecture Guide - SQL Server
How SQL Server processes queries and optimizes query reuse through execution plan caching.
Read more >
FAQ - VTA
I am coming from BART, where can I connect with VTA to get to Levi's®? ... Will there be any VTA staff out...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found