Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[transloco-messageformat] Should messageformat be a dependency?

See original GitHub issue

I’m submitting a…


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

messageformat is currently a peer dependency which means you need to explicitly install it.

Expected behavior

messageformat should be a dependency and as such be installed alongside @ngneat/transloco-messageformat by default

What is the motivation / use case for changing the behavior?

Since messageformat is required it should be a dependency rather than a peer dependency.

If this is intentional I’m interested in the reason behind it.

Issue Analytics

State:
Created 4 years ago
Comments:10 (9 by maintainers)

Top GitHub Comments

1reaction

itayodcommented, Nov 20, 2019

too late, already fixed that 😁

0reactions

NetanelBasalcommented, Nov 20, 2019

Go for it.

Top Results From Across the Web

ngneat/transloco-messageformat

Transpiler for Transloco that uses messageformat.js to compile translations using ICU syntax for handling pluralization and gender.

ngneat/transloco-messageformat - npm package

All security vulnerabilities belong to production dependencies of direct and indirect packages. ... We found a way for you to contribute to the...

Message Format | Transloco Angular i18n - GitHub Pages

Messageformat is a mechanism for handling both pluralization and gender in your app. You can see its format guide here.

Transloco Messageformat

In the bottom. left "Dependencies" panel, please install: messageformat. @ngneat/transloco-messageformat. 2. In _transloco-root.module.ts_, we must.

ngneat-transloco/lobby - Gitter

So you need to switch language twice back and forth for each language to ... Any specific reason why @ngneat/transloco-messageformat bundle size is...