Improve .get() to update whenever language is being changed with .use()

I’m submitting a … (check one with “x”)

[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[x] feature request

Current behavior Whenever I change language, parts in my code where I use .get doesn’t change. I am aware of onLangChange, but that wouldn’t make sense for me to use it.

Expected/desired behavior It should call again on subscribtion with new languages translations. I assume that observable has completed and that is why it is not calling anymore(haven’t looked at source).

Reproduction of the problem Example code of what I have now (using with ng2-breadcrumbs):

    this.translate.get(['pages.user.title', 'menus.user.profile']).subscribe((res) => {
      this.breadcrumb.addFriendlyNameForRoute('/users', res['pages.user.title']);
      this.breadcrumb.addFriendlyNameForRoute('/users/edit', res['menus.user.profile']);
    });

If I would use .onLangChange code would look something like this:

    this.translate.get(['pages.user.title', 'menus.user.profile']).subscribe((res) => {
      this.breadcrumb.addFriendlyNameForRoute('/users', res['pages.user.title']);
      this.breadcrumb.addFriendlyNameForRoute('/users/edit', res['menus.user.profile']);
    });

    this.translate.onLangChange.subscribe(() => {
      this.translate.get(['pages.user.title', 'menus.user.profile']).subscribe((res) => {
        this.breadcrumb.addFriendlyNameForRoute('/users', res['pages.user.title']);
        this.breadcrumb.addFriendlyNameForRoute('/users/edit', res['menus.user.profile']);
      });
    });

Please tell us about your environment:

• ng2-translate version: 4.0.1

• Angular version: 2.2.1

• Browser: [all]

• Language: [all]

[zsparal]

This would drastically simplify a lot of our components and I’ll even send a PR for it to - hopefully - get it into a release. Since changing the current get would silently lead to memory leaks I think adding a new function would be less destructive.

Any ideas for the function name? I’ll send the PR in the meantime but will change the name to whatever’s suggested here.

[ocombe]

Not yet, but should be in the next major