"onLangChange" subscriber in pipe does not fire

I’m submitting a …

[x] bug report

Current behavior It seems that the the onLangChange callback inside the translate pipe is not being called. If I register the callback in my application it is being called, but inside the pipe nothing happens.

Expected/desired behavior The onLangChange subscriber inside the pipe should fire

[SamVerschueren]

This is a flaw in the documentation and should be updated ASAP. You should never ever call the forRoot() of any module in the SharedModule, or feature module for that matter. There is a reason it is called forRoot, because it should only be called once in the root module, most of the time AppModule.

So move that piece of code, TranslateModule.forRoot to your AppModule and change your SharedModule to this

@NgModule({
    imports: [
        CommonModule,
        HttpModule,
        FormsModule
    ],
    declarations: [
        WelcomePageComponent,  // <--- uses the translate pipe
    ],
    exports: [
        HttpModule,
        WelcomePageComponent,
        CommonModule,
        FormsModule,
        TranslateModule
    ]
})
export class SharedModule {
    static forRoot(): ModuleWithProviders {
        return {
            ngModule: SharedModule,
            providers: [LocaleService /* <--- uses the translateService */],
        };
    }
}

[gitnik]

Thanks a lot!