Inline variable doesn't work with destructured variable declarations

Describe the scenario

“Inline variable” refactoring doesn’t work if the variable is declared via destructuring

How to reproduce

// Case 1.
// Command+Option+N ->
// Throws "I didn't found a valid code to inline from current selection 🤔" error
const { userId } = session
return messages.map(message => ({ userId }))


// Case 2.
// Command+Option+N ->
// Inlines just fine
const playerId = session.playerId
return messages.map(message => ({ playerId }))

Expected behavior

Expecting Case 1. to work

Screenshots

Additional information

• Version of the extension impacted: v0.4.0

Thank you for this amazing project btw ❤️

Progression

• Handle destructured object patterns #34
• Handle destructured array patterns #38

[nicoespeon]

Hello @noway 👋

I’ve got good news: the pattern you reported is now supported 🎉 I completed the implementation to handle destructured object patterns. It should work with complex objects too (nested cases, rest element, etc.).

I’m not closing the issue yet as it still doesn’t handle destructured array patterns (e.g. const [userId] = session). But that should be faster to implement now that we take care of object patterns.

It will be shipped in the next release (v0.8.0), on Sunday 👍

[nicoespeon]

@noway as I said, implementing the array pattern was easier now that the object pattern was implemented.

It’s now fully supported. The full support with array patterns will be shipped in the next release (probably on Sunday, I tend to release a new version every Sunday 😄).

I hope that will be as helpful to you as it is to me. Thanks again for pushing it 👍