pause(undefined) pauses a test indefinitely

If you call pause() with an undefined argument, pause will pause without completing.

module.exports = {
  test: function (browser) {
    browser.assert.ok(true, 'first'); // runs
    browser
      .pause(browser.globals.userDefinedPauseOopsTypo) // point of failure: pause(undefined)
      .perform(function () {
        browser.assert.ok(true, 'second'); // never runs, still spinning on pause
      });

  },

  after: function (browser) { browser.end(); }
};

pause could recognize undefined as 0, but I think most cases where undefined is passed (such as the example above) its in error, so it would probably be better if pause threw an error.

[senocular]

Ok I’ve changed my mind. I still don’t like having only the warning. This doesn’t help CI at all, still gumming up all the works there even if you issue a warning.

If people are using pause() for manual testing, that’s fine, but it also means they can easily change that approach to something else, i.e. its not going to break systems. Rather it will simply disrupt a couple of manual workflows.

While the solution doesn’t have to be an error, I don’t think it should hang. It should probably pause(0) and issue a warning if 0 wasn’t passed in directly. For people who want to pause indefinitely, they should use something explicit like pause(Infinity) and/or maybe allow something like a < 0: pause(-1). Something like pause(Infinity) is harder to have happen accidentally in a CI build.

Just my 2c

[senocular]

I’m OK with the arguments check + warning approach.