BeginScope forgets stuff when returning from the method

NLog version: 4.5.0

Platform: .NET Core 2.1

        [HttpGet]
        public async Task<IActionResult> Test(int id)
        {
            var item = await GetItem(id);

            _injectedLogger.LogInformation("Doing something with the item");

            return Ok();
        }

        private async Task<object> GetItem(int id)
        {
            _injectedLogger.BeginScope(new Dictionary<string, object>{["id"] = id});

            // pretend we are getting it from the database, and it takes a long time
            await Task.Delay(100);

            _injectedLogger.LogInformation($"Fetched an object from the database with id={id}");

            // pretend this is the thing we got from the database
            return new { id };
        }

In the above sample I call BeginScope inside the GetItem method, setting up the logger to include the id for the rest of the request processing. But, the id is only included in the logged message inside GetItem, in the log of the message “Doing something wit hthe item” it is missing. It seems like the value is forgotten when the async method GetItem returns.

[snakefoot]

The correct way to implement the logic would be like this:

        [HttpGet]
        public async Task<IActionResult> Test(int id)
        {
           using (_injectedLogger.BeginScope(new [] { new KeyValuePair<string, object>("id", id) }))
           {
                var item = await GetItem(id);
               _injectedLogger.LogInformation("Doing something with the item");
               return Ok();
            }
        }

Now the BeginScope-context will flow down to the GetItem()-task.

[304NotModified]

I assume your question has been answered, if not, please let us know!