Stronger type for Schema

Hello, right now Schema type is defined as:

export interface Schema {
  /** `destinationProperty` is the name of the property of the target object you want to produce */
  [destinationProperty: string]: ActionString | ActionFunction | ActionAggregator | ActionSelector;
}

What do you think about changing it to:

export interface Schema<Target> {
  /** `destinationProperty` is the name of the property of the target object you want to produce */
  [destinationProperty in keyof Target]: ActionString | ActionFunction | ActionAggregator | ActionSelector;
}

It will enforce you to map all fields in the target type, so you won’t miss any of them by mistake.

[emyann]

[emyann]

Hello @bossqone,

Thank you for this suggestion! In fact I was thinking about strengthening the link between the Schema and the Target type. Typescript interface does not accepts lookup in keys for index signature it will probably be

export type Schema<Target> = {
  /** `destinationProperty` is the name of the property of the target object you want to produce */
  [destinationProperty in keyof Target]?: ActionString | ActionFunction | ActionAggregator | ActionSelector
};

It will be like

I would prefer not to enforce the consumer to specify each property since Morphism will automatically map properties when a Class Type is provided.

class Foo {
  foo: string;
  bar: string;
}
const schema = { foo: 'qux' };
const source = { qux: 'foo', bar: 'bar' };
const fooInstance = morphism(schema, source, Foo);
// bar will be mapped from source even if it's not in the schema
// => { foo: 'foo', bar: 'bar' }

I just opened a PR here https://github.com/nobrainr/morphism/pull/34, what do you think about ?