Allow for recording user-agent request header

I know the readme clearly outlines the decision of omitting the user-agent request header from recordings. It is reiterated in the comments:

//  We never record user-agent headers as they are worse than useless -
//  they actually make testing more difficult without providing any benefit (see README)

However, please bear with me 😄 . I’m testing a scraper, which requires setting the user-agent header to a specific browser version. It would be useful if my recordings would capture that, so that if the header that I’m supposed to set explicitly is removed or changed, my tests will catch it.

I’d be willing to submit a PR for this, how do you guys feel about the following options:

• Add an include_user_agent_reqheader option to nock.recorder.rec()
• Only omit the user-agent header when a NodeJS header is detected

Cheers!

[gr2m]

hey just a heads up that I’m out vacationing until 22nd, I’ll review open issues then 😃

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!