Breaking expected Node behaviour for http.get

Related: https://github.com/nock/nock/pull/1588 and https://github.com/newrelic/node-newrelic/issues/316

New Relic (https://github.com/newrelic/node-newrelic) is overwriting http.get and http.request like you do in https://github.com/mastermatt/nock/blob/master/lib/common.js#L102. But when http.get is calling http.request like here, a call to http.get will call http.request twice when using nock in a New Relic test.

To prove that this is not native Node behaviour (at least on Node 12):

const http = require('http');

function request() {
  console.log('http.request', arguments);
}

http.request = request;

// our request function is not called
http.get('http://google.com', () => {});

Looks like this change in https://github.com/mastermatt/nock/blob/3fbc69d74f6d23b33c2c6b144aa9fbf1d855cd18/lib/common.js#L102-L104 works:

const req = newRequest(proto, overriddenGet.bind(module), [
  input,
  options,
  callback,
])
req.end()
return req

[paulmelnikow]

I’ve opened #1868 with two new tests.

[nockbot]

🎉 This issue has been resolved in version 11.8.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀