question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Drop support for Node 8; test in Node 13

See original GitHub issue

Node 8 hit end of life on 12/31 so it’s time to drop support for it.

That’s a breaking change for Nock and normally I like to batch up the breaking changes to avoid super-frequent semver major bumps. There are a few TODOS marked TODO-12.x which I’d like to push through at the same time.

We could merge some of these on the beta branch. Should we force push master to beta and then start pushing this work through?

The last time we released from the beta branch, we ended up needing to rewrite history on the commits when they were released (beta is currently on c0be8f884f85aea8662833869bd754f40c38d5da which is 235 commits ahead and 334 commits behind master). I want to try to avoid that this time, if we can!

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:11 (10 by maintainers)

github_iconTop GitHub Comments

2reactions
gr2mcommented, Feb 10, 2020

An initial git push --force base on latest master is fine, it won’t destroy any history. The new beta has nothing todo with the old beta. Ideally we would delete the beta branch once we merge a PR from beta into master

1reaction
gr2mcommented, Feb 11, 2020

The close #XYZ will only be applied once the commits are merged into the repositories main branch.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Drop Node 4 support (and Node 6 and Node 8) #3919 - GitHub
The official support for Node 4 is ending soon (April 2018) and from time to ... quite a few issues like #3875 with...
Read more >
Update Now! Node.js 8 is Not Supported from 2020.
Node 8 won't get any more updates from 2020. In this article, we'll discuss how and why you should move to newer, feature-packed, ......
Read more >
Node v8.0.0 (Current)
Node.js Long Term Support Schedule. Note that, when referring to Node.js release versions, we have dropped the "v" in Node.js 8.
Read more >
Choosing the Node.js versions for your CI tests (hint: use LTS)
While library authors are free to choose any support policy⁴ they prefer, their libraries are likely to be used in one of up...
Read more >
Update the Node.js agent | New Relic Documentation
The next major version of the New Relic Node.js agent will likely remove support for Node.js 14. Upgrade to Node.js agent version 8....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found