Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove unused deps

See original GitHub issue

I ran depcheck on this repository, and got the following result:

15:16 ~/src/nock (master) 🐕  depcheck
Unused devDependencies
* coveralls
* eslint
* glob
* istanbul
* markdown-toc
* nyc
* semantic-release

Most of these are false positives, as depcheck doesn’t check scripts, except for two, I think: istanbul is only referenced in the package.json, as far as I can tell, and glob. I think these both can probably be removed. Can someone check that they aren’t used, remove them from the package.json, and submit a PR to close this?

Issue Analytics

State:
Created 5 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

jliljacommented, Jul 14, 2018

From what I can see instanbul and glob is nowhere to be found (except from package.json).

I noticed however that we’re using request and request-promise. Maybe another issue could created for converting from request to request promise in the future?

I’ll submit a pr shortly with removed devdep.

0reactions

lock[bot]commented, Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!