Repeated interception when requests are made within Promise.all()

What is the expected behavior?

Interceptors are not persisted by default, which means that only one request will be matched and others should throw an error No match for request.

What is the actual behavior?

If requests are made within Promise.all() and registered interceptor is defined with reply with callback, it handles multiple requests. See the demonstrations below.

How to reproduce the issue

Issue reproduced where 3 requests are successful: Interceptor with reply callback Correct behavior with error thrown: Interceptor without reply callback

Does the bug have a test case?

I expect it does not have.

Versions

Software	Version(s)
Nock	12.0.1
Node	10

[mastermatt]

Given the fixes to the timing and event handling for v13, I’m not surprised unfortunately.

To fix this bug, we need the call to Interceptor.markConsumed to happen in the same microtask execution as the Interceptor matching that occurs in startPlayback. Currently, there is a setImmediate and an abort check between the two (ref).

I think we can simply move the call to markConsumed out of start and have it called just before the “finish” event is called on the request, here. I’ve started to write some tests, but I need to the day-job thing now. (I’m using this comment as notes to myself, sorry for any ramblings…) Off the top of my head, I assume moving markConsumed will work. The effect it will have is that request that is immediately aborted will consume an Interceptor, whereas before it didn’t until a full cycle of the event loop. But, I might argue this is also a bug anyway.

[gurpreetatwal]

@mastermatt thank you for the quick fix 🎉