Tests aren't cleaning up nock scope correctly

Noticed while testing https://github.com/node-nock/nock/pull/704:

1. On that PR’s branch, check out be1533746bc728bf3f136aaf9924aa10e7031bf5.
2. Run ./node_modules/.bin/tap --harmony -R spec ./tests/test_intercept.js. It’ll fail on query() will not match when the path has no query.
3. Comment out the tests above it, lines 28-4844, and run the test again – now it passes.
4. Un-comment the tests, add nock.cleanAll(); on line 4847, and run it again – it still passes.

This suggests to me that something is leaking across the tests. I’m not familiar with the tap library, but I don’t see any beforeEach or afterEach mechanism in its docs.

[erichulburd]

I’ve tried numerous different setup and teardown strategies and cannot get multiple tests to run properly with nock (running mocha and supertest). For instance:

  beforeEach(()=>{
    nock.disableNetConnect();
    nock.enableNetConnect(/^(127\.0\.0\.1|localhost)/);
  });
  afterEach(()=>{
    nock.cleanAll();
    nock.restore();
  });
  it('works on the first run', async ()=>{
   const scopes  = nock.load('./scopes1.json');
   await doSomething();
   expect(scopes.every(scope=>scope.isDone()); // true
  });
  it('does not work on the second run', async ()=>{
   const scopes  = nock.load('./scopes1.json');
   await doSomething();
   expect(scopes.every(scope=>scope.isDone()); // false
  });

package.json:

    "nock": "9.0.x",
    "mocha": "3.2.x",

[StarpTech]

I also faced with this issue. I clean up all mocks with

  afterEach((done) => {
    Nock.cleanAll()
    Nock.restore()
    done()
  })

and in every test I mock the same endpoint.

Test 1 respond with 500 Test 2 respond with 200

but now I get 500 in Test 2 because Nock.pendingMocks() still contains two entrys 😦

nock: 9.0.13 NodeJs 8