[Admin] Lower pull request approval requirement to 1

Hi @node-fetch/core,

• Per @jimmywarting’s request, I will consider lowering our merge approval count from 2 to 1 in the coming week.

• Given the number of pending changes and our team member schedule, I believe this will speed up 3.0 development considerably.

• There are definitely some risk involved; as an alternative, I am open to recruiting more active reviewers.

• If you have any other suggestions or concerns, please feel free to voice it here.

• If you support the move to lower approval requirement, please leave your vote here so we know 😃

Thx and have a nice day.

[bitinn]

Hi @jimmywarting,

If you are looking for admin access to this repo to setup some automation stuffs, please ping @Richienb and @xxczaki directly to setup a role for it. I wasn’t involved in the node-fetch org’s role settings, it would be better if they are involved.

Given current input I have changed required reviewer count to 1, to get the balls rolling on PRs.

Thx.

[Richienb]

Ideally, the amount of reviewers should not be constrained by a number we set and forget, but instead by common sense and pure logic. Following the same threshold for all pull requests doesn’t make sense since some can have a bigger impact than others.

However, having 1 as a minimum requires at least 1 other person to take a took which is fine in most circumstances though we should still internalise the fact that we should be waiting for approvals as needed rather than to just satisfy the quota.