Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

clone twice works incorrect in v3.1.0

See original GitHub issue

Call response.clone() twice cause issue in v3.1.0, in v3.0.0 it works as expected

await res.clone().text(); // here it will return the same text as res contains
await res.clone().text(); // here it will return empty

Problem I think in change that was done in clone method, it reads body from instance[INTERNALS] let {body} = instance[INTERNALS];, but then updates different property stream instance[INTERNALS].stream = p1; and body remains the same. But in v3.0.0 it both reads and then updates [INTERNALS].body

Reproduction

Steps to reproduce the behavior:

test:

it('should support clone() method', async () => {
	const body = stream.Readable.from('a=1');
	const res = new Response(body, {
		headers: {
			a: '1'
		},
		url: base,
		status: 346,
		statusText: 'production',
		highWaterMark: 789
	});
	const cl = res.clone();
	expect(cl.headers.get('a')).to.equal('1');
	expect(cl.type).to.equal('default');
	expect(cl.url).to.equal(base);
	expect(cl.status).to.equal(346);
	expect(cl.statusText).to.equal('production');
	expect(cl.highWaterMark).to.equal(789);
	expect(cl.ok).to.be.false;
	// Clone body shouldn't be the same body
	expect(cl.body).to.not.equal(body);

	await cl.text().then(result => {
		expect(result).to.equal('a=1');
	})

	const cl2 = res.clone();

	await cl2.text().then(result => {
		expect(result).to.equal('a=1');
	});
});

Fails in last expect, result is empty instead of a=1

Expected behavior

Test passed

Your Environment