Implement CODEOWNERS

https://github.blog/2017-07-06-introducing-code-owners/

We have made great strides in Node-Fetch these few months but I feel that things have been moving very fast in this repo even with having every PR reviewed by 3 people before merging.

So I am introducing CODEOWNERS.

So basically, we have a set of people that have to approve for Code Changes. Others can also approve like the maintainers, but i suggest we have 2 - 3 people approve the code. As for the 2 -3 people, I think it should be those in the @node-fetch/core for Code Changes.

For other PR’s that don’t have code change, we can have both @node-fetch/core and @node-fetch/reviewers take a look at it.

You might be thinking about why this might be needed.

In the past week, we merged 27 PR’s

Take a look in the spike of code deletions and additions

We had two releases and one was a fix.

So, we definitely need to slow things down ( mainly merging ) and take a look at reviewing code. Reviewing code is as important as writing it.

If we come to the conclusion of implementing this feature, I can get started on working on a PR.

[Richienb]

We already require at least 3 PR reviewers. In my opinion, we already have enough safeguards.

[bitinn]

If the main issue is we are merging too fast, I think an alternative solution would be to add a label that indicate a PR needs more consensus / feedbacks, such that core members shouldn’t merge too hastily.

In cases like:

• breaking changes;
• adding major features;
• build pipeline, package.json, export updates;

These PR have potential to cause issues for many users, so we should ensure reviews are being done properly and not just merge based on approval count.

It’s not always possible to find the code owner as we are probably all doing this part-time.

Preferably reviewers should write some comments after reviewing, so that people in charge of merging is not left to wonder how in-depth the review was.