NodeError: Request path contains unescaped characters

Forgive me if this has already been brought up, but I couldn’t find any previous issue about it.

Try going to example.com and opening up the console and running this:

await fetch("http://example.com?foo=网").then(r => r.text());

No error, all is well.

Now check out this runkit example.

Here’s the error:

NodeError: Request path contains unescaped characters
at new ClientRequest in core _http_client.js — line 114
at http.get in core http.js — line 41
 in node-fetch/lib/index.js — line 1327
at new Promise in core  — line 0
at Object.fetch in node-fetch/lib/index.js — line 1319

I guess the browser spec of fetch automatically escapes characters or something? I’m not sure as I haven’t looking into it. It would be nice if there were consistency here in any case.

EDIT: This error doesn’t occur in Node.js 8.x (only 10.x), so I guess there was a change in the http/https libs or something.

[wzhouwzhou]

Greetings,

I never disputed whether v6 is supported or not; v6 retired from active LTS as “maintenance” LTS with v8 labeled as the current “active” LTS version. The matter still stands that, the fact that node v11.x, a version 5 major semver releases ahead of v6, is already available as nightly and has a pending official release date, goes to show how significant the fact that v6 transitioned away from active LTS is, and how important a timely response to this issue is.

~William

[bitinn]

I am closing this as a duplicate of #245

For future reader: use require('url').URL to construct a url object and pass it to node-fetch, which will auto escape url for you.