question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

undici collaboration

See original GitHub issue

We are currently working with implementing fetch in https://github.com/nodejs/undici which is being considered for inclusion in Node core.

I was hoping that maybe we could combine some of our efforts with node-fetch. We are already using some of the tests from node-fetch (thank you and we have of course added reference and LICENSE from node-fetch).

undici is looking for what I believe is a more strict interpretation of the spec at the cost of ergonomics. I was thinking about whether it would be an idea to suggest whether node-fetch would consider using undici/fetch as it’s base implementation while providing a more node friendly interface? e.g. support for more FormData, Headers, Blob, File implementations, better node stream support etc… while keeping the fetch spec parts in undici?

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:7
  • Comments:10 (1 by maintainers)

github_iconTop GitHub Comments

4reactions
jimmywartingcommented, Aug 31, 2021

if you break out some stuff to separate packages that can be shared across node-fetch and undici (and is still compatible with node v12.20) then we could use the same stuff.

Would be grate to agree upon some packages so there isn’t duplicated code for two similar things For instance, you implemented FormData yourself instead of depending on a existing userland package

3reactions
Richienbcommented, Aug 16, 2021

Whether fetch does get implemented Node.js or more strictly in undici, the goal of node-fetch would change to backporting it to the oldest Node version still in maintenance until that becomes one that doesn’t require a ponyfill. At that point, if the community still relied on the now-legacy streams and buffers, then node-fetch may want to backport that too like suggested above.

Read more comments on GitHub >

github_iconTop Results From Across the Web

CARIATIDE EMBROIDERY X UNDICI FLORENCE
This elegant collaboration unites the architectonic lines of Undici Florence's tailored clothing, and an interpretation of the architecture of Florence using ...
Read more >
Undici Restaurant (@undicirestaurant) • Instagram photos and ...
Award-winning rustic Italian cuisine and the largest selection of Italian wines in NJ ; 983 posts ; 7,007 followers ; 705 following.
Read more >
“UNDICI”: A new Juventus-branded experience format is unveiled in ...
The space, set up during Milan Design Week 2018 in collaboration with Segafredo, will be open from 17 to 22 April. Visit. Save....
Read more >
UNDICI Restaurant | Rumson NJ - Facebook
UNDICI Restaurant, Rumson, New Jersey. ... UNDICI Restaurant is at UNDICI Restaurant. Jul 20󰞋󰟠 ... arrived This special collaboration wine with
Read more >
Gamintojo produktai - Undici ventuno
For this reason, in 2020 the brand “Undici ventuno” was established and in collaboration with Italian coffee roasting champion two exclusive freshly roasted ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found