Promise support for form.parse()

I am thinking that it could be nice to make form.parse() promisified: if no callback is provided, it will return a promise.

This could allow us to rewrite the following code:

form.parse(req, (err, fields, files) => {
  if (err) {
    // ... handle error
    return
  }

  // do something with fields and files
})

Into something like this:

try {
  const [fields, files] = await form.parse(req)
  // ... do something with fields and files
} catch (e) {
  // ... handle error
}

Is this something that has been considered already?

I had a quick look at the code and it seems that parse currently returns this (i suppose to allow method chaining). This seems to be a potential blocker for this feature (as it will require a breaking change), but as an alternative, it could be possible to create a new method called parsePromise or something similar, which can act as a wrapper for the original parse method…

The main advantages I see in supporting this syntax are the following:

• Unified error handling (one catch to rule them all)
• Integrates well with async handlers where there might be other async logic before or after the form parsing
• Fewer callbacks nesting

Thoughts?

If this idea resonates with the maintainers and the community, I’d be happy to find some time to submit a PR…

[GrosSacASac]

Should form.parse()

• awlays return a promise (vote with 👍 )
• or be callback based if a function is passed to it and else return a promise (vote with ❤️ )
• other 😕 (explain in comment)

[GrosSacASac]

No the issue is still open We are waiting for someone to make a PR