question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. ItĀ collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Reason to use `gently` in dist files?

See original GitHub issue

Hi, I’m using a third-party library (superagent) that depends on node-formidable.

My project is assembled by webpack that analyzes dependencies using some (probably standard) techniques. And it fails on this line if (global.GENTLY) require = GENTLY.hijack(require); in some of lib/* files in node-formidable. Are there any reasons to use hacked version of require in lib/* files? If no, will it be ok to submit pull request to remove it from there?

Thanks in advance.

Issue Analytics

  • State:closed
  • Created 9 years ago
  • Reactions:2
  • Comments:7

github_iconTop GitHub Comments

6reactions
felixgecommented, Nov 27, 2014

@kompot this was required for the unit tests formidable has. I think it’s still needed for them to work.

4reactions
DominicTobiascommented, Apr 5, 2019

Thanks for the solution but I’m curious why you would break a module by default for the sake of unit tests? šŸ¤”

Read more comments on GitHub >

github_iconTop Results From Across the Web

Reason to use `gently` in dist files? Ā· Issue #295 - GitHub
My project is assembled by webpack that analyzes dependencies using some (probably standard) techniques. And it fails on this line if (global.
Read more >
What is the meaning of the /dist directory in open source ...
To answer your question: /dist means "distributable", the compiled code/library. Folder structure varies by build system and programming language.
Read more >
Webpack: A gentle introduction - ui.dev
A gentle introduction to why Webpack exists, what problems it solves, and how to use it.
Read more >
A Gentle Browserify Walkthrough - Ponyfoo
CommonJS revolves around a few very straightforward rules. Every file you use is a ā€œmoduleā€. Modules are a 1-to-1 mapping to files.
Read more >
For Sale: Gently Used MP3 Music Files? - Copyright Alliance
That can mean selling the item, renting it, giving it away for free, or even throwing it in the trash. That's why you...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found