Vanilla NodeJS `request.on('end') is being called before `formidable.parse` completes

Support plan

• which support plan is this issue covered by? Community:
• is this issue currently blocking your project? yes
• is this issue affecting a production system? no

Context

• node version: 15.2.1
• module (formidable) version: 1.2.2
• environment (e.g. node, browser, native, OS): node, Windows 10
• used with (i.e. popular names of modules): Vanilla NodeJS
• any other relevant information:

What are you trying to achieve or the steps to reproduce?

Trying to upload a simple file around 100 KB. There is a branch in the code below for handling multi-part form data. We want formidable to handle that. We want to handle all other requests via the second branch.

import * as formidable from 'formidable';

// Handle incoming HTTP requests
httpServer.on('request', (request, response) => {

    let body;

    if (request.headers['content-type'].includes('multipart/form-data')) {

        formidable.parse(request, (error, fields, files) => {
            // Process multi-part form data
            body = files;
        });
    }
    else {
        request.on('data', data => {
            // Process other
            body = data;
        });
    }

    // Handle completion of the read operation above
    request.on('end', async () => {

        // Do something with body
        response.write(body);
    });
    
});

What was the result you got?

This works some of the time. But there is a race condition because the last bit request.on('end') is being called before formidable.parse completes.

What result did you expect?

One that works — I know that’s controversial.

[tunnckoCore]

@NoelAbrahams yep, something like #635 looks beautiful and modern.

[NoelAbrahams]

@tunnckoCore I’m going to close this issue, as it was really more of a question, and there doesn’t seem to be anything to fix.