stream.Duplex

Is there any technical reason this hasn’t been implemented as a stream.Duplex? The first thing I wanted to do after downloading this module was device.pipe(protocol).pipe(application), just wondering if there are any technical reasons why this isn’t the case before I take a crack at converting it over.

My use case:

var hid = require('node-hid'),
    Protocol = require('./Protocol'),
    protocol = module.exports = new Protocol(),
    devices = hid.devices();

devices
    .filter(function (device) {
        // filter devices down to those that match our interest
        return device.vendorId === Protocol.VENDOR
            && device.productId === Protocol.PRODUCT;
    })
    .map(function (device) {
        // map HID event emitter objects over devices
        return new hid.HID(device.path);
    })
    .forEach(function (device) {
        // pipe device data into protocol transformer
        device.pipe(protocol);
    });

[todbot]

Hi @bathos, Yes, if you want to do a PR with the README warning, that would be awesome. I know nothing of stream.Duplex yet but I’d be amenable to adding it. node-hid’s was written before existed I think and I have no objection to adding to its API to make it work in a more modern way.

[bminer]

I’m all for improving docs, but maybe we should change node-hid to implement the Duplex stream?