filter nodes - Filtering select should use the actual node name - not the DOM-rendered name

In the “Filter Nodes” filtering search, top of the left nav, I’ve found a behaviour I’d describe as a bug in that:

Say you have a sub module called, “My Module Foo”. The “Foo” will wrap, visually, in the sidebar nav:

My Module
Foo

But, if you go to search for the specific module in the filtering select and type, “My Module Foo” nothing is found! To find it you have to leave the space out between where it wraps. Instead, searching by, “My ModuleFoo” finds the item. I think this is bad and therefore filing a bug on the UI.

node-red: ~1.0.3 On Win10, Chrome: 78.0.3904.108 (Official Build) (64-bit) (cohort: Stable)

[dceejay]

You had offered to do it, and the other guy jumped in. Once it was pointed out - he apologised and withdrew his pull request. We want to encourage more people to contribute and leaping in ahead of them won’t encourage anybody…

Anyway net is the code was not merged - so please feel free to go ahead and create your own fix - or indeed approve his as long as it is tested and works. I haven’t checked it out so have no idea if it is the correct fix or not yet.

PS: Also don’t start adding another issue to this one… Either start another - or better yet, discuss it on the forum first. 😃

[okhiroyuki]

@neillindberg Hi. This seems to be occurring because the text is acquired in the following part.

packages/node_modules/@node-red/editor-client/src/js/ui/palette.js

    function filterChange(val) {
        var re = new RegExp(val.replace(/[-\/\\^$*+?.()|[\]{}]/g, '\\$&'),'i');
        $("#red-ui-palette-container .red-ui-palette-node").each(function(i,el) {
            var currentLabel = $(el).find(".red-ui-palette-label").text();  // ← the part
            var type = $(el).attr("data-palette-type");
            if (val === "" || re.test(type) || re.test(currentLabel)) {
                $(this).show();
            } else {
                $(this).hide();
            }
        });

Example

Demo for subflow in subflow is recognized as Demo forsubflow insubflow .