Wrong Rate limits

Hello, I try to found the best way to handle rate limits but I have some strange behaviors

const handleError = (err) => {
  const {
    shortTermUsage,
    shortTermLimit,
  } = strava.rateLimiting
  console.lg(shortTermUsage, shortTermLimit)

  throw new Error(err.message)
}

const payload = await strava.athlete.listActivities(args).catch(errors.StatusCodeError, handleError)

The error is: 429 - {"message":"Rate Limit Exceeded","errors":[{"resource":"Application","field":"rate limit","code":"exceeded"}]}

But shortTermUsage is 574 while shortTermLimit is 600

So my script stop. The next time I start my script and I go to handleError, shortTermUsage and shortTermLimit are equal to 0 like not initialized.

Did I miss something?

[markstos]

Sounds right. PR welcome.

On Mon, Feb 3, 2020, 4:22 AM Cédric Delpoux [e-mail] wrote:

The object strava.rateLimiting is correct most of the time except when the first fetch thow an error, for example if rate limit exceeded before the first fetch.

I did not try but I think we need to call rateLimiting.updateRateLimits in a catch or a finally here https://github.com/UnbounDev/node-strava-v3/blob/ee850ac6dba9b52457f84717a9d2ed4fad21fe31/lib/httpClient.js#L191

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/UnbounDev/node-strava-v3/issues/84?email_source=notifications&email_token=AAAGJZPQPJTW3IFRVO7UXLDRA7O53A5CNFSM4KL4LASKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKTC5HA#issuecomment-581316252, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGJZKRZXNS62WM3B3FVJDRA7O53ANCNFSM4KL4LASA .

[cedricdelpoux]

I just did