Node 10.0.0 Function 's toString method behaves differently than in previous versions

Node 10.0.0 yields an unexpected result when functions are converted to strings through the toString method. Here’s what happens:

• 10.0.0: (function () { }).toString() results in: 'function () { }'.
• 9.5.0: (function(){ }).toString() results in: 'function (){ }'.

The affected line is: https://github.com/nodegit/promisify-node/blob/master/utils/args.js#L9 A possible solution is to change the RegExp to: /function.*?\(([^)]*)\)/ (for example).

[tbranyen]

Fixed via #02fc47c

[awwright]

While V8 should be conservative in what it emits, I would point out this module should also be liberal in what it accepts. Both return values are indeed valid ECMAScript, and the module here should be prepared to accept any valid function, even input not directly from Function#toString.

Perhaps a full ECMAScript parser would be overkill (note that constructions such as function/**/name/**/(a)/**/{} are valid, since comments are considered whitespace), but using \s* would certainly be better.

I would propose .match(/function\s*([^(]*)\s*\(([^)]*)\)/)[2]