Change NVM_NODEJS_ORG_MIRROR to NODEJS_ORG_MIRROR to solve npm install error

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR

[superclarkk]

I see - thanks for the clarification. I don’t use node-gyp directly, but node-gyp rebuild is run automatically when node.bcrypt.js is installed, which is when this warning is generated.

It transpires that nvm sets the NVM_NODEJS_ORG_MIRROR variable in the latest version of nvm.sh and, indeed, NODEJS_ORG_MIRROR is not set.

So, it seems like bcrypt isn’t going to install correctly when NVM_NODEJS_ORG_MIRROR is removed, and end-users will have to explicitly configure NODEJS_ORG_MIRROR. It seems like a potentially unnecessary configuration step for a lot of people.

If this is the case, is there anything that can be done to make it easier for those people? Do you think ‘nvm’ should set up the new variable in its script, or is there something bcrypt can do?

[bnoordhuis]

Do you think ‘nvm’ should set up the new variable in its script

It should, and - in newer releases - it will. We discussed it with the maintainer of nvm before putting in that change.