Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

http: abort when closing with pipelining requests in flight

See original GitHub issue

Version: v16.0.0
Platform: linux
Subsystem: http

What steps will reproduce the bug?

Checkout https://github.com/fastify/fastify and run npm i:

$ node test/close-pipelining.test.js
TAP version 13
# Subtest: Should return 503 while closing - pipelining
    ok 1 - should not error
node[1156327]: ../src/node_http_parser.cc:567:static void node::{anonymous}::Parser::Initialize(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[3]->IsInt32()' failed.
 1: 0xb12b00 node::Abort() [node]
 2: 0xb12b7e  [node]
 3: 0xb2a282  [node]
 4: 0xd5f70b  [node]
 5: 0xd60bac  [node]
 6: 0xd61226 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 7: 0x160c579  [node]
Aborted

I will work on a closed reproduction soon.

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

not abort

Issue Analytics

State:
Created 2 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

indutnycommented, Apr 20, 2021

Ah, awesome. Glad it worked!

1reaction

indutnycommented, Apr 20, 2021

Ah, npm test fails indeed.

Top Results From Across the Web

Properly aborting HTTP request/response exchange on error

In a way, we want to abort the "request/response" exchange without necessarily closing the underlying http connection since we are taking advantage of...

Akka-Http client shuts down connection pool while request is ...

Occasionally the akka-http client we use will close the connection pool for a host before we receive the response from an in-flight request....

How you can abort Fetch() request on a flight… | by Oleg Lytvyn

Axios has build-in cancel() method which gives you an opportunity to abort requests which aren't yet resolved or rejected. So if you do...

HTTP/1.1: Connections

A client, server, or proxy MAY close the transport connection at any time. For example, a client might have started to send a...

What is the difference between HTTP pipelining and creating ...

However, when you're using multiple threads, there's a huge difference between pipelining requests over a single HTTP connection, and having each thread ...