Uncatchable error is thrown when a HTTPS post request fails

Bug Description

When making an HTTPS post request to a URL that doesn’t respond/exist, an AssertionError is thrown that cannot be caught by the consumer.

Reproducible By

Wrap a post request to an unreachable URL in a try…catch Observe how the script is terminated without the error being caught

Code example:

import {request} from 'undici'
try {
  await request("https://thisis.not/avalid/url", {method: "POST");
} catch {
  console.log("Error caught, this never happens");
}

Expected Behavior

The promise should be rejected so that the error can be caught and handled by the consumer

Logs

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(this.servername)

    at TLSSocket.<anonymous> (C:\path\node_modules\undici\lib\core\connect.js:61:11)
    at TLSSocket.emit (node:events:377:35)
    at emitErrorNT (node:internal/streams/destroy:193:8)
    at emitErrorCloseNT (node:internal/streams/destroy:158:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: null,
  expected: true,
  operator: '=='
}

Environment

Windows 10, Node v16.2.0

[joaopedrocampos]

Hey guys! If still up to, I would love to try this fix 🙏

[ronag]

Merged fix