Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Fallback function is being executed when errorFilter is applied
See original GitHub issueNode.js Version: v12.18.2
Operating System: macOS 10.15.7 (19H114)
Steps to Produce Error:
According to https://github.com/nodeshift/opossum#fallback, the fallback function is supposed to be executed only when the circuit is open. But, when the error filter returns true, (for eg: error filter is applied to exclude HTTP 404, errorFilter: err => err.statusCode < 500) the circuit remain closed and the fallback function is still being executed.
The issue seems to be here: https://github.com/nodeshift/opossum/blob/3cb7de98259ecbbfed4dcf9b8ee5187367049907/lib/circuit.js#L658-L664
Would you be able to check if the fallback is supposed to be called in this scenario? Thanks
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (4 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Just released this fix in 6.0.0
Hi @jerrin. This is a good catch. It’s actually working as intended, but the docs don’t reflect that. A little over a year ago, this was discussed in a pull request. My original ask was to change this behavior so that fallback would not be called. But ultimately we didn’t go that route because it was considered a breaking change. @lholmquist should we revisit this?