Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Scanner broken when targeting Android 12+

See original GitHub issue

This looks to be preventing us from targeting 12 at the moment.

 java.lang.IllegalArgumentException: co.dance.rider: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
    Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
        at android.app.PendingIntent.checkFlags(PendingIntent.java:375)
        at android.app.PendingIntent.getBroadcastAsUser(PendingIntent.java:645)
        at android.app.PendingIntent.getBroadcast(PendingIntent.java:632)
        at no.nordicsemi.android.support.v18.scanner.BluetoothLeScannerImplOreo.createStartingPendingIntent(BluetoothLeScannerImplOreo.java:171)

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:9 (8 by maintainers)

Top GitHub Comments

1reaction

roumcommented, Sep 30, 2021

@philips77 I’ve been testing the changes in #108 on our fork, and though it does prevent fatal crashes on Android 12+ caused by the mutability flag not being explicitly set, it now prevents scan results from being received in PendingIntentReceiver (i.e. the intent received has no extras). This tells me that the correct flag there may be FLAG_MUTABLE, which can only be used if the project targets API 31 which it currently doesn’t.

This issue may need to be reopened, and hopefully inspire a deeper look into how the project can safely target 31.

1reaction

roumcommented, Aug 25, 2021

PR https://github.com/NordicSemiconductor/Android-Scanner-Compat-Library/pull/108