v2.0 Tracking Issue

As mentioned in #262 request is deprecated. If we are replacing it with something else it’s a breaking change and needs to be done as a major release, thus tracking towards v2.0.

An incomplete list of things to be done before v2.0

• Replace deprecated request dependency, axios may be the best contender. fetch may not work as intended for the test suite but would otherwise be the clear winner.
• Remove deprecated endpoints
• Look into what to do with Proxies and TypeScript #221
• Remove underscore function calls maps

[JamesxX]

1. IMO proxies should be removed, .fetch() methods are what should be used to fetch content. I think the library API should follow this standard:

   const subreddit = requester.getSubreddit("r/redditdev")
   await subreddit.fetch()
   

I think a neat solution might be that proxies are simply of type Partial<SnoowrapObject>, and fetch returns a full SnoowrapObject. This would allow for more type safety as it would become obvious at compile time whether a variable is being accessed before it is assigned.

[iMrDJAi]

@OmgImAlexis Yeah I didn’t think about it at the beginning. I realized that we can just let developers install polyfills separately instead of including them on the library.
Anyway, I already made a progress with axios, I even added support for some old properties from the request API to gain a maximum backward compatibility.