IsValidShopDomainAsync throws HttpRequestException when the shop name is invalid (not url)
See original GitHub issueI think this function is supposed to handle all invalid case, including malfunctioned Url:
string urlFromUser = "foo";
bool isValidDomain = await AuthorizationService.IsValidShopDomainAsync(urlFromUser);
Current behavior: throwing HttpRequestException.
Expected: return false
.
Issue Analytics
- State:
- Created 6 years ago
- Comments:7 (6 by maintainers)
Top Results From Across the Web
How do I get StatusCode from HttpRequestException?
Looks like I can either: Use the message to switch the status code (bleh); Or create my version of EnsureSuccessStatusCode and throw exception ......
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Just published 4.8.3 to nuget, it’ll show up for download in the next 20 minutes. Thanks for the pull request!
It should be available in 4.8.3 within the next 45 minutes. As soon as the tests finish on AppVeyor I can publish to nuget and it takes about 20 minutes there before you can download it.