question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

IsValidShopDomainAsync throws HttpRequestException when the shop name is invalid (not url)

See original GitHub issue

I think this function is supposed to handle all invalid case, including malfunctioned Url:

string urlFromUser = "foo";
bool isValidDomain = await AuthorizationService.IsValidShopDomainAsync(urlFromUser);

Current behavior: throwing HttpRequestException. Expected: return false.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
nozzlegearcommented, Jan 10, 2018

Just published 4.8.3 to nuget, it’ll show up for download in the next 20 minutes. Thanks for the pull request!

1reaction
nozzlegearcommented, Jan 10, 2018

It should be available in 4.8.3 within the next 45 minutes. As soon as the tests finish on AppVeyor I can publish to nuget and it takes about 20 minutes there before you can download it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I get StatusCode from HttpRequestException?
Looks like I can either: Use the message to switch the status code (bleh); Or create my version of EnsureSuccessStatusCode and throw exception ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found