Rename services in 5.0

I’d like to rename all of the services we have right now to remove the Service suffix. There’s no real reason to have it, plus it makes the FulfillmentServiceService sound kinda silly. I’m thinking of just pluralizing the name of the object they deal with, so OrderService would become Orders and FulfillmentServiceService would become FulfillmentServices.

[nozzlegear]

Sure, I don’t mind the FulfillmentServiceService so much, but FulfillmentService and FulfillmentServiceEntity are a little confusing when none of the other entities have an “Entity” suffix. Maybe a better solution would be namespacing the services and entities to ShopifySharp.Services and ShopifySharp.Entities.

[davron12]

If you’re going to change or remove the suffix, I’d lean towards a different suffix rather than pluralized. I can foresee the following if you go the pluralized route:

var orders = new Orders();
var orders = await orders.ListAsync();

Namespacing would remove the FulfillmentService problem as well, and would follow the folder-namepace best practice. The problem is, it’s going to break a lot of existing code. Well, any of these suggested changes are going to break existing code.