Map NodaTime Interval to tstzrange

I somehow managed to miss NodaTime’s Interval type. This is a perfect match for PostgreSQL tstzrange, similarly to how we map DateInterval to PostgreSQL daterange.

[madmox]

I can easily get around the issue because I use Dapper on top of npgsql and already have type handlers so that Dapper correctly maps properties with non default types, so the fix is not top-priority. I even updated the handler so that it accepts both Interval[] and NpgsqlRange<Instant>[], in case the fix is integrated later and I forget about the issue when upgrading my nugets.

public class IntervalListHandler : SqlMapper.TypeHandler<List<Interval>>
{
    public override List<Interval> Parse(object value)
    {
        // Looks like npgsql incorrectly maps tstzrange[] to NpgsqlRange<Instant>[]
        // although it correctly maps tstzrange to NodaTime.Interval.
        // See https://github.com/npgsql/npgsql/issues/4070 for details.

        if (value is NpgsqlRange<Instant>[])
        {
            var typedValue = (NpgsqlRange<Instant>[])value;
            return typedValue?.Select(x => new Interval(x.LowerBound, x.UpperBound)).ToList();
        }
        else
        {
            var typedValue = (Interval[])value;
            return typedValue?.ToList();
        }
    }

    public override void SetValue(IDbDataParameter parameter, List<Interval> value)
    {
        parameter.Value = value;
        ((NpgsqlParameter)parameter).NpgsqlDbType = NpgsqlDbType.Array | NpgsqlDbType.Range | NpgsqlDbType.TimestampTz;
    }
}

But I opened the issue 😃

[roji]

@madmox the non-contiguous aspect of multiranges may indeed be a reason to continue using arrays, true.

If using NodaTime Interval[] is important for you, please open a new issue - I can’t promise I’ll get around to it immediately though.