Consider API changes for the next release
See original GitHub issueCutting a major release is the time to make breaking changes to the API so we should consider what (if any) we should make. One that comes to mind is renaming the soiling.srr_analysis
class to use CamelCase.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:5 (2 by maintainers)
Top Results From Across the Web
API Versioning: A Marketer's Guide - HubSpot Blog
All changes to your API, from small updates to new releases, should be made clear to clients. If you need to sunset a...
Read more >API Versioning: When and How to Do It Successfully
Oftentimes, when new API versions are released, the old ones will stay active for some time, providing developers with enough time to make ......
Read more >5 stages of an API lifecycle explained - TechTarget
APIs change over time, as developers keep up with business needs, ... Continuously releasing new versions of an API can be troublesome for ......
Read more >How to Discuss API Changes During Code Review - Optic
Using Optic to Review and Discuss API Changes During Code Reviews ... Next, you need to initialize Optic in your project's root directory....
Read more >What Are Breaking Changes and How Do You Avoid Them?
What are breaking changes? And how can we avoid them? Here are best practices to avoid and mitigate breaking changes for your API...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Sorry for the vagueness. The new functionality would allow all precipitation events greater than some specified threshold to be counted as cleaning events.
To be consistent with the way
precip_clean_only
works, we would do it without modifying thesoiling_interval_summary
dataframe.precip_clean_only
currently works by only allowing soiling recoveries on cleaning events that coincided with precipitation thresholds, but the slopes are still found independently for the sub-parts of the interval separated by detected cleaning events that did not coincide with rain.But thinking this through it may be overall more consistent to handle both cases earlier in the algorithm, before slopes are fit for each interval.
I gave Kevin the few lines of code I used to combine detected shifts and rain for using as intervals. What we talked about is inserting another option for the user besided precip_clean_only…detected_clean_and_precip or something like that and the user could select this option. The Theil-sen fits would then be calculated on these intervals (this is what I did in my version) for the soiling map.