docker build failing after upgrade to @nrwl/workspace 13.4.6

Current Behavior

After the upgrade to version 13.4.6 of @nrwl/workspace, docker builds are failing as the build commands are assuming that git is available, which won’t be the case in most docker builds that use slim base images.

Expected Behavior

As in versions <13.4.6, I’d expect the build commands to not attempt executing git since git won’t always be available, for various reasons.

Steps to Reproduce

To reproduce the issue, take a look at https://github.com/bahizi/nx-docker-build. Clone the repo and try running a simple docker build . in the root directory.

The fix/docker-build branch will work as expected, since there we’re using @nrwl/workspace@13.4.5

Failure Logs

> nx-docker-build@0.0.0 ng /home/airline
> nx "run" "api:build"

events.js:377
      throw er; // Unhandled 'error' event
      ^

Error: spawn git ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:274:19)
    at onErrorNT (internal/child_process.js:469:16)
    at processTicksAndRejections (internal/process/task_queues.js:82:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:280:12)
    at onErrorNT (internal/child_process.js:469:16)
    at processTicksAndRejections (internal/process/task_queues.js:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn git',
  path: 'git',
  spawnargs: [ 'ls-files', '-s', '-z', '--exclude-standard', '.' ]
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! nx-docker-build@0.0.0 ng: `nx "run" "api:build"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the nx-docker-build@0.0.0 ng script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Environment

Docker. The node:14.18.2-alpine3.14 image

[sjjk001]

I have had the same issue but I have managed to fix it. I had to install git in the container as nx makes use of git history. Try apt-get update && apt-get install git or apk update && apk add git.

[bahizi]

After looking at this more, figured out a simple and elegant way to solve the issue without installing git in my container image: add .git to the .dockerignore file.

Sample fix in the original ‘reproduce’ repo, in the fix/update-gitignore branch: https://github.com/bahizi/nx-docker-build/tree/fix/update-gitignore.