Don't crash build on TSC errors

• I’d be willing to implement this feature (contributing guide)

Description

Usually I load these env variables to NOT crash the dev server on linting/tsc errors:

ESLINT_NO_DEV_ERRORS=true
TSC_COMPILE_ON_ERROR=true

But because these aren’t prefixed with NX_, they are ignored in nx, thus making the server crash on every little temporary error.

Motivation

Cut down dev time and frustration

Suggested Implementation

1. introduce an easy way to override this crashing behavior, and have it be the default
2. support non NX_ prefixed env variables
3. Make this configuration available cross projects, i.e. I could globally set these env variables on all projects instead of manually setting them up for each new one.

Alternate Implementations

🤷‍♀️

[Ofadiman]

I think that dev server does not crash but there is an overlay from webpack with error messages being displayed in the browser. I was able to disable the overlay by creating a custom webpack config according to this tutorial.

In my project.json I updated the targets.build.options.webpackConfig key to point to the created webpack config:

{
  ...
  "targets": {
    "build": {
      ...
      "options": {
        ...
        "webpackConfig": "apps/client/webpack.config.js"
      }
    },
    "serve": {...},
    "lint": {...},
    "test": {...}
  },
  "tags": []
}

My webpack config looks as follows:

const { merge } = require('webpack-merge')

module.exports = (config, _context) => {
  return merge(config, {
    devServer: {
      client: {
        // https://webpack.js.org/configuration/dev-server/#overlay
        overlay: {
          errors: false,
          warnings: false,
        },
      },
    },
  })
}

If I try to build the project via npx nx run client:build I still get typescript compilation errors so this change seems to affect only the development workflow.

[goldylucks]

Guys any progress here?

@Ofadiman any ideas?