feat: @nrwl/storybook: stories are not linted - it's on purpose or a bug?

Expected Behavior

I see two options how to approach this:

• use tsconfig.json as lint entry point within architect lint target

"lint": {
          "builder": "@nrwl/linter:lint",
          "options": {
            "linter": "eslint",
            "config": "libs/react-one/.eslintrc",
            "tsConfig": [
-              "libs/react-one/tsconfig.lib.json",
-              "libs/react-one/tsconfig.spec.json"
+              "libs/react-one/tsconfig.json"
            ],
            "exclude": ["**/node_modules/**", "!libs/react-one/**"]
          }
        },

• generate tsconfig.stories.json when storybook:init is executed and update particular project workspace.json accordingly

"lint": {
          "builder": "@nrwl/linter:lint",
          "options": {
            "linter": "eslint",
            "config": "libs/react-one/.eslintrc",
            "tsConfig": [
              "libs/react-one/tsconfig.lib.json",
              "libs/react-one/tsconfig.spec.json"
+              "libs/react-one/tsconfig.stories.json"
            ],
            "exclude": ["**/node_modules/**", "!libs/react-one/**"]
          }
        },

with tsconfig.stories.json

{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "outDir": "../../dist/out-tsc",
    "types": [
      "node"
    ]
  },
  "include": [
    "**/*.stories.ts",
    "**/*.stories.js"
  ]
}

Current Behavior

• .stories are not linted

Context

>  NX  Report complete - copy this into the issue template

  @nrwl/angular : Not Found
  @nrwl/cli : 9.2.3
  @nrwl/cypress : 9.2.3
  @nrwl/eslint-plugin-nx : 9.2.3
  @nrwl/express : Not Found
  @nrwl/jest : 9.2.3
  @nrwl/linter : 9.2.3
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : 9.2.3
  @nrwl/react : 9.2.3
  @nrwl/schematics : Not Found
  @nrwl/tao : 9.2.3
  @nrwl/web : 9.2.3
  @nrwl/workspace : 9.2.3
  typescript : 3.8.3

[juristr]

Question: will lint builder properly resolve provided relative path? “include”: [“…/src/**/*”] see source

🤔 good question. I did a quick try by referencing the .storybook/tsconfig and it seemed to work. But guess you’ll have to give it a try and test some edge-cases to be 100% sure 😃

I’ll try to send PR till end of this week 🤞

cool 🎉. Just let me or @mandarini know if you have any doubts or questions.

[juristr]

Hey @Hotell 👋 . Just discussed the options with @mandarini. We would go with option 1, so

1. fix the matching of the stories in the react storybook setup as you correctly pointed out
2. add the storybook tslint to the linter configuration in angular.json / workspace.json. But instead of generating a new one we could directly use the one in the .storybook/tsconfig.json which is generated inside the lib that has storybook support.

Would be cool if you could provide a PR on this 🙂