Generating react library causes tests to fail after upgrading to 10.3.0

Current Behavior

Generate a data-access library under an existing directory completes successfully. After this running jest tests errors out on any of the libs with

(oldOptions[key] || []).map is not a function

Expected Behavior

The tests should run successfully.

Steps to Reproduce

Write some lib tests that pass for all libs

yarn nx run-many --target=test --all

Create a new library by running this command:

nx generate @nrwl/react:library --name=data-access --directory=ui/main --no-component --tags='scope:ui-main, type:data-access'

Run tests again

Failure Logs

(oldOptions[key] || []).map is not a function

Environment

  nx : 10.3.0
  @nrwl/angular : Not Found
  @nrwl/cli : 10.3.0
  @nrwl/cypress : 10.3.0
  @nrwl/eslint-plugin-nx : 10.3.0
  @nrwl/express : 10.3.0
  @nrwl/jest : 10.3.0
  @nrwl/linter : 10.3.0
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : 10.3.0
  @nrwl/react : 10.3.0
  @nrwl/schematics : Not Found
  @nrwl/tao : 10.3.0
  @nrwl/web : 10.3.0
  @nrwl/workspace : 10.3.0
  typescript : 4.0.3

Downgrading back to 10.2.1 fixes the problem.

One difference i noticed is in the lib’s jest.config.js

module.exports = {
  ...
  preset: "../../../../jest.config.js", // <-- this value is ../../../../jest.preset.js in 10.3.0
  ...
};

[tmakola]

I experience the same issue after upgrading to 10.3.0. In my case, it was after adding a new node library which seems to me not at all to be related to React but libraries in general. nx g @nrwl/node:library now-version.

What I noticed is the jest.config.js in the root folder had an additional property added to it that seemed to lock Jest to a specific project. Therefore only the newly added project was testable.

Removing the file, allowed all tests from all projects to function again.

module.exports = {
    ...
    passWithNoTests: true,
    projects: '<rootDir>/libs/now-version' // <--- newly added property. should be removed
};

[ZackDeRose]

Hi all - going back to my reproduction if you trace back through the commits, you can see that while I create a migrations.json file, I entered the command incorrectly as:

nx migrate --run-migrations

Whereas prior versions (pre 11.4) required a target migrations.json file (so like so: nx migrate --run-migrations=migrations.json).

As such, these migrations were generated, but not ran. We’ve added more clarity around this in current versions - the cli prompts with nx migrate --run-migrations=migrations.json and we also now default to migrations.json if no explicit path is provided.

To others having issues with this in their workspaces after migrating, you can rerun this migration specifically by creating a migrations.json with the contents:

{
  "migrations": [
    {
      "version": "10.3.0-beta.1",
      "description": "Adds all jest projects into the root jest config",
      "factory": "./src/migrations/update-10-3-0/update-projects-property",
      "package": "@nrwl/jest",
      "name": "update-projects-property"
    }
  ]
}

And then run nx migrate --run-migrations=migrations.json to correct your workspaces going forward.

Also note that the projects property on your root jest.config.json exists to enable tooling with VsCode (and other IDEs) that allows your IDE to target and these tests correctly (see below). Removing the projects property from your root jest.config.json - or removing this file entirely - will allow your tests to be run via the nx CLI, but running jest tests via your IDE may break.