question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

@nrwl/node: showCircularDependencies false still show WARNING after upgrading typescript version to >= 3.5

See original GitHub issue

Please make sure you have read the submission guidelines before posting an issue

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I’m reporting the issue to the correct repository (not related to Angular, AngularCLI or any dependency)

Expected Behavior

showCircularDependencies:false should disable Circular Dependency warning

Current Behavior

showCircularDependencies:false still showing Circular Dependency warnings

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. sample project https://github.com/xmlking/ngx-starter-kit
  2. ng serve api

Context

Please provide any relevant information about your setup:

Angular CLI: 8.2.0-next.1
Node: 12.6.0
OS: darwin x64
Angular: 8.2.0-rc.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker


 nx 8.4.0

Failure Logs

ng serve api
Starting type checking service...
Using 14 workers with 2048MB memory limit
Version: typescript 3.5.3
Time: 8039ms
Hash: fee1cdba394376a1fffb
Built at: 07/28/2019 11:23:43 AM
Entrypoint main [big] = main.js main.js.map
chunk {main} main.js, main.js.map (main) 270 KiB [entry] [rendered]

WARNING in Circular dependency detected:
apps/api/src/app/core/core.module.ts -> apps/api/src/app/user/index.ts -> apps/api/src/app/user/user.module.ts -> apps/api/src/app/user/profile/profile.controller.ts -> apps/api/src/app/core/index.ts -> apps/api/src/app/core/core.module.ts

WARNING in Circular dependency detected:
apps/api/src/app/core/entities/audit-base.ts -> apps/api/src/app/user/index.ts -> apps/api/src/app/user/user.module.ts -> apps/api/src/app/user/profile/profile.controller.ts -> apps/api/src/app/core/index.ts -> apps/api/src/app/core/core.module.ts -> apps/api/src/app/project/project.entity.ts -> apps/api/src/app/core/entities/audit-base.ts

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:3
  • Comments:25 (19 by maintainers)

github_iconTop GitHub Comments

4reactions
johannesschobelcommented, Oct 1, 2019

Dear @vsavkin and @xmlking , i was able to reproduce this issue in my own setup (nestjs only application). If you like i can provide a small reproduction repository?

2reactions
xmlkingcommented, Sep 3, 2019

please note: you have to use typescript version 3.5 or above to reproduce this issue. typescript v3.4 works fine.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Developers - @nrwl/node: showCircularDependencies false still ...
nrwl/node : showCircularDependencies false still show WARNING after upgrading typescript version to >= 3.5.
Read more >
Angular CLI: False positive circular dependency warning ...
The Angular Material source code for Dialog shows that an Injector is used to instantiate the Component to be displayed in the Dialog....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found