@nrwl/node:build package.json not including all external dependencies.

Current Behavior

Code contains two dependencies

• express
• morgan

On serve or build. The generated package.json does not include morgan as a dependency, only express is included in package.json

project.targets.build.options.generatePackageJson = true

{
  "name": "sample-api",
  "version": "0.0.1",
  "dependencies": {
    "express": "^4.17.1"
  },
  "main": "main.js"
}

Expected Behavior

I expected the output of package.json to include morgan as a dependency.

{
  "name": "sample-api",
  "version": "0.0.1",
  "dependencies": {
    "express": "^4.17.1",
    "morgan": "version"
  },
  "main": "main.js"
}

Steps to Reproduce

1. create nx workspace.
2. create new application using @nrwl/node.
3. create a express server with morgan middleware

import * as express from 'express'
import * as morgan from 'morgan'

const app = express()

app.use(morgan('common'))
app.get('/', (req ,res) => {
  return res.status(200).json({ message:'sample api'})
})

const port = 3000 || process.env.APP_PORT

app.listen(port, () => {
  console.log(`App listening on http://localhost:${port}`)
})

1. In workspace.json set project.targets.build.options.generatePackageJson = true .
2. Change build location to apps/app_name/build .
3. Run nx r sample-api:serve or nx r sample-api:build .
4. check apps/app_name/build/package.json . package.json does not include morgan as dependency.

Project entry in workspace.json

 "sample-api": {
      "root": "apps/sample-api",
      "sourceRoot": "apps/sample-api/src",
      "projectType": "application",
      "targets": {
        "build": {
          "executor": "@nrwl/node:build",
          "outputs": ["{options.outputPath}"],
          "options": {
            "progress": true,
            "generatePackageJson": true,
            "outputPath": "apps/sample-api/dist",
            "main": "apps/sample-api/src/main.ts",
            "tsConfig": "apps/sample-api/tsconfig.app.json",
            "assets": ["apps/sample-api/src/assets"]
          },
          "configurations": {
            "production": {
              "optimization": true,
              "extractLicenses": true,
              "inspect": false,
              "fileReplacements": [
                {
                  "replace": "apps/sample-api/src/environments/environment.ts",
                  "with": "apps/sample-api/src/environments/environment.prod.ts"
                }
              ]
            }
          }
        },
        "serve": {
          "executor": "@nrwl/node:execute",
          "options": {
            "buildTarget": "sample-api:build"
          }
        },
        "lint": {
          "executor": "@nrwl/linter:eslint",
          "options": {
            "lintFilePatterns": ["apps/sample-api/**/*.ts"]
          }
        },
        "test": {
          "executor": "@nrwl/jest:jest",
          "outputs": ["coverage/apps/sample-api"],
          "options": {
            "jestConfig": "apps/sample-api/jest.config.js",
            "passWithNoTests": true
          }
        }
      }
    },

This issue may not be prioritized if details are not provided to help us reproduce the issue.

Failure Logs

N/A

Environment

node 14 ubuntu LTS 20

[moterink]

I am having the same issue - it seems like some dependencies, especially those from libs are not included in the generated package.json. This makes containerizing a single application really difficult.

[Mistic92]

I have the same issue with a lot more packages like nestjs config, gcp storage, luxon