1.19.0: tests failure on s390x

Hello, I’ve recently uploaded numpy/1.8.3 to debian, and the test suite reported a failure when running with the debug flavor of python3.8 on the architecture s390x, full log at https://buildd.debian.org/status/fetch.php?pkg=numpy&arch=s390x&ver=1%3A1.18.3-1&stamp=1587351308&raw=0 , extract:

___________________ TestRationalFunctions.test_gcd_overflow ____________________

self = <numpy.core.tests.test_umath.TestRationalFunctions object at 0x3ffa1549dc0>

    def test_gcd_overflow(self):
        for dtype in (np.int32, np.int64):
            # verify that we don't overflow when taking abs(x)
            # not relevant for lcm, where the result is unrepresentable anyway
            a = dtype(np.iinfo(dtype).min)  # negative power of two
            q = -(a // 4)
>           assert_equal(np.gcd(a,  q*3), q)
E           AssertionError: 
E           Items are not equal:
E            ACTUAL: -2305843009213693952
E            DESIRED: 2305843009213693952

a          = -9223372036854775808
dtype      = <class 'numpy.int64'>
q          = 2305843009213693952
self       = <numpy.core.tests.test_umath.TestRationalFunctions object at 0x3ffa1549dc0>

tmp/usr/lib/python3/dist-packages/numpy/core/tests/test_umath.py:2599: AssertionError
= 1 failed, 10243 passed, 85 skipped, 180 deselected, 18 xfailed, 2 xpassed in 90.10 seconds =

[rgommers]

are these tests part of the ci for every PR or do these tests run elsewhere ? I tried looking, in the CI I mostly found tests for x64, i686.

There’s an s390x job in .travis.yml, it runs the test suite on every PR.

[sandrotosi]

just note that this build failures are not fatal for the debian build, as they tend to appear from time to time on this uncommon architectures. So i usually just let them fail and report the error back her for your attention.

if you decide to add a skipIf i’d just leave it there, but i usually dont add it as patch in debian as then i’d have to disable them with every new release, detect which ones are still valid, remove the ones that are fixed, etc etc; feels just extra work with little gain