Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consider reverting the renaming of compiled c test modules (part of the pytest move)?

See original GitHub issue

The renaming of compiled c test modules in #10790 broke the scikit-learn tests because we were using numpy.core.umath_tests.inner1d. There was no good reason to use inner1d and we now used standard numpy constructs in scikit-learn master. The problem is that it will affect the latest scikit-learn (0.19.1) as soon as numpy 1.15 is released. Given the current rate of release, it is rather likely that numpy 1.15 will be released before the next scikit-learn release (0.20).

It feels like other projects could be using some of the renamed modules, so maybe the safest approach would be to keep the old modules around for a deprecation cycle with a DeprecationWarning saying that this modules are for numpy internal use only. Would you be willing to consider this option?

I first commented in https://github.com/numpy/numpy/pull/10790#issuecomment-378285426 but @charris suggested I opened a new issue, so here it is!

Issue Analytics

State:
Created 5 years ago
Comments:20 (16 by maintainers)

Top GitHub Comments

2reactions

rthcommented, Apr 4, 2018

The problem is that it will affect the latest scikit-learn (0.19.1) as soon as numpy 1.15 is released.

By affect, @lesteve means that it will raise an error if one imports anything from sklearn.ensemble (cf. https://github.com/scikit-learn/scikit-learn/pull/10880#issuecomment-378245618 ) which will break existing code for a number of scikit-learn users…

0reactions

a-recknagelcommented, Sep 5, 2018

For deprecation- and user-warnings, pytest does it on its own by default. I’ll open an issue then.

edit: @charris https://github.com/numpy/numpy/issues/11883

Top Results From Across the Web

Changelog — pytest documentation

SkipTest to skip collection of tests during the pytest collection phase is reverted - this is now a supported feature again.

setup_* executed before all fixtures · Issue #517 · pytest-dev ...

I think the proper way to fix this issue is to internally turn setupClass/Module methods into appropriate pytest autouse fixtures. This way setupClass...

Test discovery failure when tests in different directories are ...

test, two tests called the same in different directory causes py.test to fail. Why is that? How can I change this without renaming...

pytest Documentation - Read the Docs

Each collected test is assigned a unique nodeid which consist of the module filename followed by specifiers like class.

Unit test reports - GitLab Docs

If JUnit report format XML files are generated and uploaded as part of a pipeline, these reports can be viewed inside the pipelines...