Do not use localhost:3000 as default in production

What problem does this feature solve?

If eveything else fails, baseURL will default to http://localhost:3000.

While this is nice in dev environement, it might cause production environement to use http://localhost:3000 as default, if not configured properly.

This lead to error in my deployment because I didn’t configure the module correctly but din’t realise my mistake until it was too late.

I believe that a better behaviour would be to throw ASAP in that case, preventing the deployment of faulty code.

What does the proposed changes look like?

let defaultPort =
  // ...
  (process.env.NODE_ENV === 'development' && 3000)

let defaultHost =
  // ...
  (process.env.NODE_ENV === 'development' && 'localhost')

if (!defaultPort || !defaultHost) throw new Error('Configuration error')

<div align="right">_{This feature request is available on Nuxt community (#c267)}</div>

[nzakas]

This is a really confusing default behavior, it took me a while to figure out why my API calls were failing. I agree with @matthieusieben – when I say /api/foo, it is logical to expect that this request will go to the same host/port as the page that is calling it.

[pi0]

@manniL Indeed baseURL is auto-generated with port/host of the listener server if not provided:

https://github.com/nuxt-community/axios-module/blob/dev/lib/module.js#L17

This issue is requesting to make setting baseURL manually mandatory for non-dev and not using server host/port to generate it.